Godot Blackholio completion#5030
Conversation
lisandroct
force-pushed
the
lisandro/godot-blackholio-completion
branch
from
d9a4371 to
0c10ba6
Compare
lisandroct
force-pushed
the
lisandro/godot-blackholio-completion
branch
2 times, most recently
from
af82eb5 to
c2f7cb9
Compare
lisandroct
force-pushed
the
lisandro/godot-blackholio-completion
branch
from
c2f7cb9 to
562bb5d
Compare
lisandroct
force-pushed
the
lisandro/godot-blackholio-completion
branch
from
562bb5d to
32fae12
Compare
bfops
left a comment
bfops
left a comment
There was a problem hiding this comment.
The CI part looks pretty good to me, minus a few small comments. It looks like the CI is failing, though.
rekhoff
left a comment
rekhoff
left a comment
There was a problem hiding this comment.
The C# code looks good to me.
I tested project by building into a Windows executable (which did require me to generate a blackholio.sln file for the client), and then tested using multiple clients/computers. All UI elements appear to function correctly, you can eat each other, split apart, and force a death of your clients character.
I also ran the tests locally, and they appear to work. Running godot --headless --path .\SpacetimeDB\demo\Blackholio\client-godot --scene res://tests/GodotPlayModeTests.tscn gave passing tests in the CLI output:
[GodotTests] START SimpleConnectionTest
SpacetimeDBClient: Connecting to ws://127.0.0.1:3000 blackholio
[GodotTests] PASS SimpleConnectionTest
[GodotTests] START CreatePlayerAndTestDecay
SpacetimeDBClient: Connecting to ws://192.168.50.120:3000 blackholio
Connected.
Subscription applied!
[GodotTests] PASS CreatePlayerAndTestDecay
[GodotTests] START OneOffQueryTest
SpacetimeDBClient: Connecting to ws://192.168.50.120:3000 blackholio
Connected.
Subscription applied!
[GodotTests] PASS OneOffQueryTest
[GodotTests] START ReconnectionViaReloadingScene
SpacetimeDBClient: Connecting to ws://192.168.50.120:3000 blackholio
Connected.
Subscription applied!
SpacetimeDBClient: Connecting to ws://192.168.50.120:3000 blackholio
Connected.
Subscription applied!
[GodotTests] PASS ReconnectionViaReloadingScene
rekhoff
left a comment
rekhoff
left a comment
There was a problem hiding this comment.
With all CI jobs completed, and I believe all comments have been addressed, I am making this as approved.
4 participants
Description of Changes
API and ABI breaking changes
Expected complexity level and risk
Testing